Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @storybook@6.4.22 #129787

Merged
merged 30 commits into from
May 19, 2022
Merged

Bump @storybook@6.4.22 #129787

merged 30 commits into from
May 19, 2022

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Apr 7, 2022 •
edited
Loading

@patrykkopycinski patrykkopycinski force-pushed the chore/renovate-storybook branch from 7c89655 to 049f827 Compare April 28, 2022 07:18
@patrykkopycinski patrykkopycinski changed the title Bump @storybook Bump @storybook@6.4.22 May 2, 2022
@patrykkopycinski patrykkopycinski marked this pull request as ready for review May 2, 2022 15:01
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner May 2, 2022 15:01
YulNaumenko
YulNaumenko approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Solution LGTM!

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

miltonhultgren
miltonhultgren approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM 👍🏼

jughosta
jughosta approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery change LGTM, thanks!

mbondyra
mbondyra approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For VisEditors change, it would be good to take advantage of type object value property to describe the shape of the object (thanks @Kunzetsov for suggestion!) but we can do this separately - after talking to Patryk he explained he wants to keep this PR small so we can add our changes later on.

Approved 👌🏼

ThomThomson
ThomThomson approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team storyshot and typings changes LGTM!

patrykkopycinski and others added 3 commits May 13, 2022 19:15
@patrykkopycinski @mbondyra
Apply suggestions from code review
32f3bc8 
Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/renovate-…
4669ff4 
…storybook

# Conflicts:
#	yarn.lock
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/renovate-…
476f659 
…storybook

# Conflicts:
#	package.json
#	yarn.lock
gbamparop
gbamparop approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

afgomez
afgomez approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/renovate-…
7ca8610 
…storybook

# Conflicts:
#	package.json
#	yarn.lock
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +59.0B
securitySolution 5.0MB 5.0MB +9.0B
total +68.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 338 343 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 4.8MB 4.8MB -396.0B
Unknown metric groups

API count

id before after diff
@kbn/storybook 22 38 +16

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit ae0c683 into elastic:main May 19, 2022
@patrykkopycinski patrykkopycinski deleted the chore/renovate-storybook branch May 19, 2022 10:03
@mistic mistic mentioned this pull request Jun 12, 2023
Closed
Ikuni17 pushed a commit to Ikuni17/kibana that referenced this pull request Jun 15, 2023
@patrykkopycinski @Ikuni17
Bump @storybook@6.4.22 (elastic#129787)
caecc94
@Ikuni17 Ikuni17 mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@gbamparop gbamparop gbamparop approved these changes

@mbondyra mbondyra mbondyra approved these changes

@jbudz jbudz jbudz approved these changes

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@jughosta jughosta jughosta approved these changes

@nchaulet nchaulet nchaulet approved these changes

@afgomez afgomez afgomez approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:skip This commit does not require backporting chore ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.